Skip to content
This repository has been archived by the owner on Mar 21, 2024. It is now read-only.

Fix to support wrapping CUB in a custom outer namespace with macros #225

Merged
merged 1 commit into from
Nov 5, 2020
Merged

Fix to support wrapping CUB in a custom outer namespace with macros #225

merged 1 commit into from
Nov 5, 2020

Conversation

elstehle
Copy link
Collaborator

Fixes #222

Verified using the following example from issue #222

#define CUB_NS_PREFIX namespace {
#define CUB_NS_POSTFIX }
#include <cub/cub.cuh>
int main()
{
        int res = (int)cub::Equals<int, int>::VALUE;
        return res;
}

@alliepiper alliepiper self-assigned this Oct 27, 2020
@alliepiper alliepiper added this to the 1.11.0 milestone Oct 27, 2020
@alliepiper alliepiper added testing: gpuCI in progress Started gpuCI testing. testing: gpuCI passed Passed gpuCI testing. and removed testing: gpuCI in progress Started gpuCI testing. labels Oct 28, 2020
@alliepiper
Copy link
Collaborator

DVS CL: 29265328

@alliepiper alliepiper added the testing: internal ci in progress Currently testing on internal NVIDIA CI (DVS). label Oct 30, 2020
@alliepiper alliepiper added testing: internal ci passed Passed internal NVIDIA CI (DVS). and removed testing: internal ci in progress Currently testing on internal NVIDIA CI (DVS). labels Nov 3, 2020
@alliepiper alliepiper merged commit 1a5aeaf into NVIDIA:main Nov 5, 2020
@alliepiper alliepiper mentioned this pull request Nov 16, 2020
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@alliepiper alliepiper alliepiper approved these changes

Assignees

@alliepiper alliepiper

Labels
testing: gpuCI passed Passed gpuCI testing. testing: internal ci passed Passed internal NVIDIA CI (DVS).
Projects
None yet
Milestone
1.11.0
Development

Successfully merging this pull request may close these issues.

Compile fails with anonymous namespace CUB_NS_PREFIX
2 participants
@elstehle @alliepiper